ngraham added a comment.
Thanks for the ping, @cfeck. And thanks for the patch @auxym! May it be the
first of many. :)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28941
To: auxym, #plasma, davidedmundson, apol
Cc: ngraham, cfeck, plasma-devel, Orage, Le
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ed09a3baf3e0: startplasma: Sort environment scripts prior
to sourcing (authored by auxym, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
cfeck added a comment.
It looks like the submitter doesn't have commit rights.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28941
To: auxym, #plasma, davidedmundson, apol
Cc: cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zach
auxym updated this revision to Diff 80511.
auxym added a comment.
Fix a comment
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28941?vs=80510&id=80511
REVISION DETAIL
https://phabricator.kde.org/D28941
AFFECTED FILES
startkde/startplasma.cpp
auxym updated this revision to Diff 80510.
auxym added a comment.
Use priority as returned by QStandardPaths::standardLocations and sort in the
entryInfoList() call.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28941?vs=80466&id=80510
REVISION
auxym added a comment.
Good option, I had not noticed that in the QT docs. I felt using startsWith()
was a bit hackish anyways. Plus, since entryInfoList() has a sort param, I
won't even need the sort call.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28
davidedmundson added a comment.
Concept makes sense.
QStandardPaths is ordered: "The list of directories is sorted from high to
low priority, starting with writableLocation()"
so we can cut this code in half by doing some sort of
void runEnvironmentScripts()
{
const a
auxym created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
auxym requested review of this revision.
REVISION SUMMARY
Sort environment scripts before they are sourced. User scripts should run
after system scripts to ensure that user preferences take pre
