D28832: Avoid creating subwindow on internal page widget

2020-04-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R871:262389b1e49b: Avoid creating subwindow on internal page widget (authored by davidedmundson). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28832?vs=80133&id=80138

D28832: Avoid creating subwindow on internal page widget

2020-04-14 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I am kind of thinking the cast should be asserted or if'd. But I suppose that doesn't add much over just letting it crash on the null dereference. REPOSITORY R871 DrKonqi BRANCH master

D28832: Avoid creating subwindow on internal page widget

2020-04-14 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KWallet::openWallet takes a windowId as a parameter. QWidget->winId() is