D28709: Implement executeScript for Firefox

fvogt added a comment. In D28709#645296 , @broulik wrote: > I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the s

D28709: Implement executeScript for Firefox

broulik added a comment. So, back to my export function patch? :/ REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28709: Implement executeScript for Firefox

broulik added a comment. I've originally injected breeze scroll bar CSS as style with src in the extension but that also cause other issues where websites weren't allowed to access the different origin of the style sheet... REPOSITORY R856 Plasma Browser Integration REVISION DETAIL http

D28709: Implement executeScript for Firefox

fvogt abandoned this revision. fvogt added a comment. https://bugzilla.mozilla.org/show_bug.cgi?id=1591983 :-( I guess spotify had `unsave-eval`, but not `unsafe-inline`, so this method just breaks different pages... Apparently it's possible to add a `script` element with ´src="moz-

D28709: Implement executeScript for Firefox

broulik added a comment. Try https://open.spotify.com/browse/featured but I believe you can't play anything without an account. Maybe you could upload an ogg file to KDE nextcloud and try with that. REPOSITORY R856 Plasma Browser Integration BRANCH ffeval REVISION DETAIL https://pha

D28709: Implement executeScript for Firefox

fvogt added a comment. I just tried this with google translate on FF ESR 68(.1.0 IIRC) and it worked, but there was an error about the content security policy having blocked an eval. The error is gone if the extension is disabled. So this needs a test with spotify/nextcloud. Do you have any

D28709: Implement executeScript for Firefox

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thank you so much! I tested with all the players from D24870 and it works really well. REPOSITORY R856 Plasma Browser Integration BRANCH ffeval

D28709: Implement executeScript for Firefox

broulik added a comment. At a glance this seems to be working marvellously. Even media session API works in Spotify now REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren

D28709: Implement executeScript for Firefox

broulik added a comment. Try whether it works on Spotify web player and nextcloud - they have a content security policy which prevents adding custom script tags REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc:

D28709: Implement executeScript for Firefox

fvogt added a comment. I'm not sure about the `// Firefox enforces Content-Security-Policy also for scripts injected by the content-script` part, but I'm not sure how to test it. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #pl

D28709: Implement executeScript for Firefox

fvogt added a comment. Note: Remains to be tested on non-firefox and old firefox ESR. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28709 To: fvogt, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28709: Implement executeScript for Firefox

fvogt updated this revision to Diff 79729. fvogt added a comment. Use full URL in comment REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28709?vs=79728&id=79729 BRANCH ffeval REVISION DETAIL https://phabricator.kde.org/D28709 AFFEC

D28709: Implement executeScript for Firefox

fvogt created this revision. fvogt added reviewers: Plasma, broulik. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY window.eval is exactly what we need, so we can drop the Firefox specific replacements like calls to exportFunction. TEST PLAN Restar