D28651: Load and use global animation settings

ngraham added a comment. Agreed. @sandsmark, would you be interested in following up with that? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze, ngraham Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #br

D28651: Load and use global animation settings

hpereiradacosta added a comment. Thanks for this change ! Can the same be done in the breeze window decoration ? It is strange to have an animation settings there and not in the style. Hugo REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #b

D28651: Load and use global animation settings

ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze, ngraham Cc: meven, cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampalou

D28651: Load and use global animation settings

meven added inline comments. INLINE COMMENTS > breezestyle.cpp:189 > +QStringLiteral( "org.kde.KGlobalSettings" ), > +QStringLiteral( "notifyChange" ), this, > SLOT(configurationChanged()) ); > #if QT_VERSION < 0x050D00 // Check if Qt version < 5.13 Shouldn't it

D28651: Load and use global animation settings

davidedmundson added a comment. Just push it. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampa

D28651: Load and use global animation settings

sandsmark added a comment. Should I move this to invent, or just push it? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: cblack, davidedmundson, ngraham, hpereiradacosta, ndavis, plasma-devel, #breeze, Orage, LeGast00n, The-Feren-OS-D

D28651: Load and use global animation settings

ngraham added a subscriber: cblack. ngraham added a comment. Works for me now. @hpereiradacosta, @ndavis, and @cblack, are you okay with this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: cblack, davidedmundson, ngraham, hpereiradac

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 80551. sandsmark added a comment. Remove the duplication of animation control, and don't override the animation settings if people haven't adjusted it globally. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28651?vs=7

D28651: Load and use global animation settings

ngraham added a comment. In D28651#646418 , @sandsmark wrote: > I think it makes sense to have it both places, having it in the breeze settings avoids people having to go back and forth to tune their settings. I'm afraid I don't agree. H

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#647122 , @davidedmundson wrote: > As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically rep

D28651: Load and use global animation settings

davidedmundson added a comment. As for runtime changes I'm trying to migrate more things to KConfigWatcher which I wrote to replace random ad-hoc ints everywhere as well as making sure we automatically reparse the config once and only once. It's going to be /amazing/ but it's being rolle

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#646572 , @ndavis wrote: > You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. I usually just push normally after approval, but I'

D28651: Load and use global animation settings

ndavis added a comment. You need to fix the git author info. If you upload a patch via the web UI instead of `arc`, the author info gets messed up. It's still working for me. I also still need to restart apps for changes to the global animation settings to apply. REPOSITORY R31 Breeze

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79916. sandsmark added a comment. Now should reload the animation settings when changed anywhere. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28651?vs=79914&id=79916 REVISION DETAIL https://phabricator.kde.org/D28

D28651: Load and use global animation settings

sandsmark added a comment. In D28651#643681 , @ndavis wrote: > I don't know enough about KDE configuration management to judge the code, but with this patch, changing animation speeds in SySe works if I restart apps after the change. The

D28651: Load and use global animation settings

sandsmark updated this revision to Diff 79914. sandsmark added a comment. Also made it store to the global configuration. This way it is backwards compatible, but the config can also be changed from both places. I think it makes sense to have it both places, having it in the breeze setti

D28651: Load and use global animation settings

ndavis added a comment. I don't know enough about KDE configuration management to judge the code, but changing animation speeds in SySe works if I restart apps after the change. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ngraham,

D28651: Load and use global animation settings

ngraham added a comment. I agree with Hugo that if we make Breeze respect the new global animation speed slider, we should remove the user-facing setting in Breeze's own settings to control the animation speed. Having two config knobs for ostensibly the same thing (or more accurately, one ad

D28651: Load and use global animation settings

hpereiradacosta added a comment. I have no idea how this is supposed to work. But the current fix overwrites what's in the breeze configutation, right ? Would it not lead to utter confusion ? These settings should be set at one place and one only. Whether breeze or global I have no strong

D28651: Load and use global animation settings

ndavis added a comment. So this makes Breeze respect the global animation speed setting in the Workspace Behavior - > General Behavior KCM? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: ndavis, plasma-devel, #breeze, Orage, LeGast00n

D28651: Load and use global animation settings

sandsmark created this revision. sandsmark added a reviewer: Breeze. sandsmark added a project: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sandsmark requested review of this revision. REVISION SUMMARY In addition to the specific Breeze animation settings, KD