D28614: Add better player tab crash handling

This revision was automatically updated to reflect the committed changes. Closed by commit R856:b50818455f89: Add better player tab crash handling (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28614?vs=79454&id=79602

D28614: Add better player tab crash handling

ngraham accepted this revision. ngraham added a comment. I have the same issue with Firefox and can confirm that this fixes it! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack, ngraham Cc: ngraham, plasma-d

D28614: Add better player tab crash handling

broulik added a comment. Waiting for @cblack since they were who mentioned this issue REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28614: Add better player tab crash handling

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. For false positives the player would get added again by the `playing` event, which is not ideal, but as it doesn't require a reload it's IMO close enough. REPOSITORY R856 Plasma Browser Int

D28614: Add better player tab crash handling

fvogt added a comment. In D28614#642630 , @broulik wrote: > > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? > > I believe whenever a player starts playing agai

D28614: Add better player tab crash handling

broulik added a comment. > If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? I believe whenever a player starts playing again, it is propagated through MPRIS again. The `playerGone` handling is no different fr

D28614: Add better player tab crash handling

fvogt added a comment. If there is a false positive in the detection, how would those be handled? AFAICT the players would never appear in mpris again? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D28614 To: broulik, #plasma, fvogt, cblack Cc: p

D28614: Add better player tab crash handling

broulik created this revision. broulik added reviewers: Plasma, fvogt, cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There is unfortunately no dedicated signal for this (the process API is for dev bui