D28473: BookmarksRunner: Early return and formatting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e518d45a4d61: BookmarksRunner: Early return and formatting (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79086&id=81648 REVI

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Ping, regarding the question :-) REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Should this(and the following patches) go to a stable branch, because they fix a bug that has been reported (418526)? REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://phabricator.kde.org/D2847

D28473: BookmarksRunner: Early return and formatting

bruns added a comment. LGTM - @broulik ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, h

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79086. alex added a comment. Use categories for warnings, cleanup imports REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79083&id=79086 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) R

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:166 > +if (!QSqlDatabase::isDriverAvailable(QStringLiteral("QSQLITE"))) { > +qWarning() << "SQLITE driver isn't available"; > +return; Thanks, though I was wrong about "no categories yet". #include "bookmarks_debug

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79083. alex added a comment. Implement warnings REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79019&id=79083 BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://p

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:198 > -if (profilePath.isEmpty()) { > -//qDebug() << "No default firefox profile found"; > -return; Can you leave this in, and even promote it to an active qWarning* - if we have a db and prof

D28473: BookmarksRunner: Early return and formatting

alex updated this revision to Diff 79019. alex added a comment. Implement requested changes. PS: I had already tested the migration locally and added it to the test plan. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28473?vs=79017&id=79019

D28473: BookmarksRunner: Early return and formatting

broulik added a comment. > Should compile and work exactly as before. Please always test `QRegularExpression` migration, I've seen just too many regressions when this wasn't done carefully INLINE COMMENTS > firefox.cpp:171 > +/* This allows the user to specify a profile database */

D28473: BookmarksRunner: Early return and formatting

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY As requested in D28196 this patch handles the early return and the formatting. Additionally QRegul