bshah added inline comments.
INLINE COMMENTS
> davidedmundson wrote in server_p.cpp:234
> "This" will lack any context when someone is actually debugging this.
"This" debug statement should be removed :P
> davidedmundson wrote in server_p.cpp:245
> I assume you forgot to have an
>
> iface.Clos
bshah updated this revision to Diff 78961.
bshah marked 2 inline comments as done.
bshah added a comment.
- fix comments by David
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28454?vs=78951&id=78961
BRANCH
bshah/greeter-notify
REVISION DETAIL
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Seems pretty simple and sensible.
1 minor fixup needed.
INLINE COMMENTS
> server_p.cpp:234
> +hints, notification.timeout());
> +qCDebug(N
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
This is alternative to previous revision which talks to ksldapp and then
ksldapp talks to the greeter over private wayland server inte
