D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-31 Thread Bhushan Shah
bshah added a subscriber: broulik. bshah added a comment. > +1 to using global and per-notification blacklists rather than a per-notification whitelist Plan is to change this in future, but for now to keep code simple I and @broulik agreed on this solution. (Also I am closing this d

D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-30 Thread Nathaniel Graham
ngraham added a comment. In D28427#637913 , @nicolasfella wrote: > So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From

D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-30 Thread Bhushan Shah
bshah updated this revision to Diff 78884. bshah added a comment. - adapt to changes in the kscreenlocker REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28427?vs=78871&id=78884 BRANCH bshah/ksld-notify REVISION DETAIL https://phabricator.kde.

D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-30 Thread Nicolas Fella
nicolasfella added a comment. So notifications are only forwarded if x-kde-show-on-lockscreen is set? I wonder if opt-out (x-kde-dont-show-on-lockscreen) would be better with regard to third-party apps. From a privacy POV I think a global dont-show-notis-on-lockscreen thing would make more s

D28427: [libnotificationmanager] forward notifications to lockscreen

2020-03-30 Thread Bhushan Shah
bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This is currently WIP, and doesn't fully work, requires patches on both kscreenlocker and lockscreen theme. TEST PLAN tested that d