D28330: Color icons in titlebar if possible

This revision was automatically updated to reflect the committed changes. Closed by commit R31:a1e1a53f3b73: Color icons in titlebar if possible (authored by davidre). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=79068&id=79556 REVISION DETAIL http

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 79068. davidre added a comment. Be more careful when resetting palette REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78860&id=79068 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.k

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78860. davidre added a comment. forgot else REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78859&id=78860 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28330 AFFECTED FIL

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:153 > +KIconLoader::global()->resetPalette(); > +} > KWin doesn't change the palette, it uses to global one to draw the icons for example when you right click on a window titlebar. REPOSITORY R31

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78859. davidre added a comment. Check if cast is successfull REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78639&id=78859 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:151 > decoration()->client().data()->icon().paint(painter, > iconRect.toRect()); > - > +KIconLoader::global()->resetPalette(); > I will look into it REPOSITORY R31 Breeze BRANCH icons (branched fr

D28330: Color icons in titlebar if possible

kossebau added a comment. With cross-casting I meant the type of cast where the types involved are not in same inheritance branch INLINE COMMENTS > davidre wrote in breezebutton.cpp:148 > I don't think it can fail. decoration() is a QPointer > (https://api.kde.org/kdecoration/html/classKDec

D28330: Color icons in titlebar if possible

davidre added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPalet

D28330: Color icons in titlebar if possible

kossebau added inline comments. INLINE COMMENTS > breezebutton.cpp:148 > +QPalette palette = decoration()->client().data()->palette(); > +palette.setColor(QPalette::Foreground, > qobject_cast(decoration())->fontColor()); > +KIconLoader::global()->setCustomPale

D28330: Color icons in titlebar if possible

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Quite nice, quite nice. REPOSITORY R31 Breeze BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28330 To: davidre, #plasma, #vdg, ngraham Cc: ngraha

D28330: Color icons in titlebar if possible

davidre updated this revision to Diff 78639. davidre added a comment. Use decoration()->fontColor() REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28330?vs=78618&id=78639 BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D2

D28330: Color icons in titlebar if possible

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Some icons can be recolored. However if the titlebar color is different compared to the normal color scheme, this can lead to bad