D28234: Use SyntaxHighlighter for highlighting

2020-03-25 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R871:f304e0185fb8: Use SyntaxHighlighter for highlighting (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28234?vs=78354&id=78446 REVISION DETAIL h

D28234: Use SyntaxHighlighter for highlighting

2020-03-25 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I love it! INLINE COMMENTS > backtracewidget.cpp:230 > +m_highlighter = new > KSyntaxHighlighting::SyntaxHighlighter(ui.m_backtraceEdit->document()); > + > m_highli

D28234: Use SyntaxHighlighter for highlighting

2020-03-24 Thread Aleix Pol Gonzalez
apol added a comment. F8196700: Screenshot_20200324_145906.png REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28234 To: apol, #plasma, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fba

D28234: Use SyntaxHighlighter for highlighting

2020-03-24 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The code is especially fiddly and complex. Using this we can on the other hand leverage other part