D28103: Support multiple stacked Passive Notifications

2020-03-19 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R169:659324f28ec6: Support multiple stacked Passive Notifications (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77942&id=77986 REVISION D

D28103: Support multiple stacked Passive Notifications

2020-03-18 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > broulik wrote in PassiveNotification.qml:35 > Just `padding`? actually, it would make the implicitHeight calculation fail (it's dumb like that and that's why for the new property inset they only added leftInset topInset etcand not a simple inset on

D28103: Support multiple stacked Passive Notifications

2020-03-18 Thread Marco Martin
mart updated this revision to Diff 77942. mart marked 2 inline comments as done. mart added a comment. - fix quick spawning of notifications REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28103?vs=77934&id=77942 BRANCH mart/passivenotification REVISION

D28103: Support multiple stacked Passive Notifications

2020-03-18 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > PassiveNotification.qml:26 > + > +x: parent.width/2 - width/2 > +y: parent.height - height - Kirigami.Units.smallSpacing `Math.round` please > PassiveNotification.qml:35 > + > +topPadding: Kirigami.Units.smallSpacing > +leftPaddin