broulik added inline comments.
INLINE COMMENTS
> shadowedrectangle.h:161
> protected:
> +void itemChange(QQuickItem::ItemChange change, const
> QQuickItem::ItemChangeData &value);
> QSGNode *updatePaintNode(QSGNode *node, QQuickItem::UpdatePaintNodeData
> *data) override;
Missing `ov
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:848b5a7345f9: check for window existence (authored by
mart).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28067?vs=77708&id=77710
REVISION DETAIL
https://phab
ahiemstra accepted this revision.
ahiemstra added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> shadowedrectangle.cpp:178
> +
> +void ShadowedRectangle::checkSoftwareItem()
> +{
Just a minor nitpick: Please move this to the end of the file so that the
metho
mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.
REVISION SUMMARY
not always after componentcompleted a window is already there.
if is not there, do the same check whe
