D27979: Add top area to notifications

ngraham added a comment. Sorry. With no //header text.// REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27979 To: niccolove, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenB

D27979: Add top area to notifications

niccolove added a comment. In D27979#643330 , @ngraham wrote: > So I think the padding issue isn't related to fonts after all. I noticed while doing a backup today that there's no spacing between the header and the content underneath it even whe

D27979: Add top area to notifications

ngraham added a comment. So I think the padding issue isn't related to fonts after all. I noticed while doing a backup today that there's no spacing between the header and the content underneath it even when there's no text. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabr

D27979: Add top area to notifications

niccolove added a comment. I will add the padding in the todo list :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27979 To: niccolove, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27979: Add top area to notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ca7a9bcbbc1f: Add top area to notifications (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27979?vs=79065&id=79149 REVISION DETAI

D27979: Add top area to notifications

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The padding looks much better with default font settings: F8211692: Screenshot_20200402_090740.png I'm using 11pt Ubuntu though, not 10pt Noto S

D27979: Add top area to notifications

niccolove added a comment. Weird, I do see a margin. Do you have any idea what could case this issue (us seeing different things)? I assumed that the margin was given by the qml Heading default topmargin F8211176: Screenshot_20200402_112236.png REPOS

D27979: Add top area to notifications

ngraham added a comment. This looks amazing! I love it. I think the content area below the header needs an additional `units.smallSpacing` margin though. The text in that area comes really close to touching the header: F8209858: Screenshot_20200401_115821.png