This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f444ebe595a2: Port some usage of QRegExp to
QRegularExpression (authored by ahmadsamir).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27857?vs=77906&id=7
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> calculatorrunner.cpp:199
>
> -if (cmd.contains(QRegExp(QStringLiteral("\\d+and\\d+" {
> - cmd.replace(QRegExp(QStringLiteral("(\\d+)and(\\d+)")),
> QStrin
ahmadsamir updated this revision to Diff 77906.
ahmadsamir added reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.
Verbatim
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27857?vs=77905&id=77906
BRANCH
l-qregexp-QRE (branched
ahmadsamir updated this revision to Diff 77905.
ahmadsamir added a comment.
Verbatim
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27857?vs=77898&id=77905
BRANCH
l-qregexp-QRE (branched from master)
REVISION DETAIL
https://phabricator.kde.or
ahmadsamir added inline comments.
INLINE COMMENTS
> apol wrote in server.cpp:671
> Why the changes from [0-9] to \d?
Less cluttered; but maybe not as readable. I'll revert it.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27857
To: ahmadsamir, #plasma
Cc: p
ahmadsamir updated this revision to Diff 77898.
ahmadsamir marked 2 inline comments as done.
ahmadsamir removed reviewers: davidedmundson, apol, broulik.
ahmadsamir added a comment.
Address comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27
apol added a comment.
+1 overall
INLINE COMMENTS
> ksolidnotify.cpp:131
> QString out(p->readAll());
> -const QStringList &pidList =
> out.split(QRegExp(QStringLiteral("\\s+")), QString::SkipEmptyParts);
> +const QStringList &pidList =
> out.
ahmadsamir added a comment.
Ping.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27857
To: ahmadsamir, #plasma, davidedmundson, apol, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenB
ahmadsamir created this revision.
ahmadsamir added a reviewer: Plasma.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.
REVISION SUMMARY
[0-9] is \d
TEST PLAN
make && ctest
REPOSITORY
R120 Plasma Workspace
BRANCH
l-qregexp-QRE (branched from master)
REVISIO
