D27650: Don't use guarded pointers for AppletsLayout

2020-02-26 Thread Aleksei Nikiforov
alnikiforov added a comment. In D27650#617550 , @davidedmundson wrote: > > This function takes a plain pointer and wraps it into weak shared pointer. > > That's QWeakPointer. > > QPointer is something else that doesn't have an equivalent

D27650: Don't use guarded pointers for AppletsLayout

2020-02-25 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > This function takes a plain pointer and wraps it into weak shared pointer. That's QWeakPointer. QPointer is something else that doesn't have an equivalen

D27650: Don't use guarded pointers for AppletsLayout

2020-02-25 Thread Aleksei Nikiforov
alnikiforov created this revision. alnikiforov added reviewers: ngraham, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alnikiforov requested review of this revision. REVISION SUMMARY Using these pointer types incorrectly leads to premature destruc