D27522: Fix date-label size in vertical layout

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now using the "Long Date" setting in a double-width panel results in the following: F8118081: Screenshot_20200221_071729.png And "Sho

D27522: Fix date-label size in vertical layout

carewolf updated this revision to Diff 76092. carewolf added a comment. Fixing also for short data and very long dates REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27522?vs=76055&id=76092 BRANCH Plasma/5.18 REVISION DETAIL https://phabricat

D27522: Fix date-label size in vertical layout

ngraham added a comment. Well your patch doesn't regress anything for me, so if it fixes it for you, that's good. Still it might be good to have some clarity here so we understand what's going on! :p REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2752

D27522: Fix date-label size in vertical layout

carewolf added a comment. In my case the text was too small. I wonder how exactly Text.Fit works, if it just increases font-size for short format to fill width that could make it too big. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewo

D27522: Fix date-label size in vertical layout

ngraham added a comment. Thanks for the patch! Looks like this doesn't fully fix the issue though. With "Short Date" I see the following: F8116070: Screenshot_20200220_140027.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D27522: Fix date-label size in vertical layout

ngraham added a comment. (The bug I'm thinking of is https://bugs.kde.org/show_bug.cgi?id=417728) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27522: Fix date-label size in vertical layout

carewolf added a comment. It only affects vertical panels, it is in the vertical panel configuration. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jral

D27522: Fix date-label size in vertical layout

ndavis added a comment. Does this work well with vertical panels? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen

D27522: Fix date-label size in vertical layout

carewolf updated this revision to Diff 76055. carewolf added a comment. Fix the logic to what was probably originally meant. Elided is still disabled as it triggers too aggresively on narrow fits. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27522: Fix date-label size in vertical layout

carewolf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carewolf requested review of this revision. REVISION SUMMARY The text was smaller than than minimum configuration, and also smaller than the width allowed for. REPOSITORY R120 Plasma Wor