D27505: Do not crash when icon's width or height is 0

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fcae16b30b06: Do not crash when icon's width or height is 0 (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27505?vs=76002&id=76043 REVISI

D27505: Do not crash when icon's width or height is 0

ahiemstra added a comment. In D27505#614240 , @davidedmundson wrote: > Would be good to dump this test qml somewhere in the repo. A folder full of tests which just have one component in a bunch of configurations. > I've been pushing for that

D27505: Do not crash when icon's width or height is 0

ahiemstra added a comment. It most likely does, since Icon also has no implicit width/height it will default to 0 and crash when there's no special layout properties specified. REPOSITORY R169 Kirigami BRANCH icon_crash REVISION DETAIL https://phabricator.kde.org/D27505 To: ahiemstra

D27505: Do not crash when icon's width or height is 0

ngraham added a comment. Does this fix https://bugs.kde.org/show_bug.cgi?id=417844? REPOSITORY R169 Kirigami BRANCH icon_crash REVISION DETAIL https://phabricator.kde.org/D27505 To: ahiemstra, #kirigami, davidedmundson Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, dom

D27505: Do not crash when icon's width or height is 0

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Weird. plasma-framework's version of icon (which this is copied from) has had that check for years. Would be good to dump this test qml somewhere in the repo. A folder f

D27505: Do not crash when icon's width or height is 0

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY When Icon's width or height is 0, I get a crash with the following backtrace: #0