D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Nathaniel Graham
ngraham added a comment. Yes I at least look at all new patches for Plasma, Frameworks, and many KDE apps. If I'm capable of reviewing them, I do. If not, I try to add people to the reviewers list who I think can, if they're not already marked as reviewers. We can add you as a reviewer f

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment. So you review all patch from all repo ? :) awesome ! I am not able to do it! And I don't want to do it otherwise no possible to work on my projects. But I am happy that you do it ! :) So for sure I will not review all patchs from framework/plasma, but I am not

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Nathaniel Graham
ngraham added a comment. In D27408#613637 , @mlaurent wrote: > no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me. > I will not subscribe for each commit in plasma/frame

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment. no each reviews but when you create a patch for qt5.15 as I was the only dev which worked on qt5.15 it was logical to add me. I will not subscribe for each commit in plasma/framework, for sure after 20-30 commits I will not read them. I have ~ 200 mails by days, so

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Aleix Pol Gonzalez
apol added a comment. In D27408#613598 , @mlaurent wrote: > Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't add me as reviewer ? )?

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Laurent Montel
mlaurent added a comment. In D27408#613565 , @ngraham wrote: > @mlaurent ^^ Just a question: How I can see it if nobody adds me as reviewer (if I remember I was the only one guys who works against qt5.15 from several months so why don't

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Nathaniel Graham
ngraham added subscribers: mlaurent, ngraham. ngraham added a comment. @mlaurent ^^ REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27408 To: apol, #plasma Cc: ngraham, mlaurent, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27408: Fix build with Qt 5.15.0

2020-02-18 Thread Aleix Pol Gonzalez
apol abandoned this revision. apol added a comment. Abandoned because @lmontel just commits changes instead of reviewing other people's patches. :( REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D27408 To: apol, #plasma Cc: plasma-devel, Orage,

D27408: Fix build with Qt 5.15.0

2020-02-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY currentIndexChanged(int) is reprecated and bound to be removed. TEST PLAN Builds REPOSITORY R121 Poli