D27367: fix activity runner

2020-02-18 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a979a4bbebe: fix activity runner (authored by McPain, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27367?vs=75900&id=75928 REVIS

D27367: fix activity runner

2020-02-18 Thread Oleg Solovyov
McPain updated this revision to Diff 75900. McPain marked an inline comment as done. McPain added a comment. removed 2nd hunk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27367?vs=75605&id=75900 REVISION DETAIL https://phabricator.kde.org/D27367 AFFECTED FILES runners/activit

D27367: fix activity runner

2020-02-13 Thread David Edmundson
davidedmundson added a comment. Urgh. I suspect this was a hidden bug from when runnermanager never emitted teardown. Given how runnermanager currently seems to work, this patch does make sense. INLINE COMMENTS > activityrunner.cpp:79 > { > +delete m_activities; > +m_activities

D27367: fix activity runner

2020-02-13 Thread Oleg Solovyov
McPain created this revision. McPain added reviewers: broulik, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. McPain requested review of this revision. REVISION SUMMARY Activity runner is now useless: m_activities is always nullptr in Activ