gvgeo added a comment.
I logged with my main account and I get lots of
file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17:
QML Label: Binding loop detected for property "width"
REPOSITORY
R119 Plasma Desktop
REVISION DET
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6b1cc98f0959: [Folder view] Fix binding loop on width
(authored by ngraham).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27261?vs=75470&id=75471
REVISION
ngraham updated this revision to Diff 75470.
ngraham added a comment.
One more
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27261?vs=75469&id=75470
BRANCH
fix-folderview-binding-loop (branched from master)
REVISION DETAIL
https://phabricator.
ngraham updated this revision to Diff 75469.
ngraham added a comment.
Use identical margins; don't change the visuals at all (should be done in
another patch if necessary)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27261?vs=75427&id=75469
BRANC
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
It's technically different to before. The old code had half a small margin
each side.
Generally speaking bug fixes shouldn't change things, as then you're mixing
differ
gvgeo added a comment.
Also adds smallSpacing at the top. It would not look right with Plasma
Components Label, which already has empty space top and bottom. PC3 on the
other hand has none...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27261
To: ngraham,
ngraham updated this revision to Diff 75427.
ngraham added a comment.
Re-add margins, and also add missing bottomMargin
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27261?vs=75285&id=75427
BRANCH
fix-folderview-binding-loop (branched from master
gvgeo added a comment.
This removes the smallSpacing. Text will touch the edges.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27261
To: ngraham, #plasma
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This fixes the binding loop and replaces a complicated bit of code with
something much
simpler.
