D27061: replace samba module with data that works

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f1768f7b3ab9: replace samba module with data that works (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27061?vs=75170&id=75272#toc REPOSITORY R102 KInfoCenter CHANGES

D27061: replace samba module with data that works

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm happy with the model. As for 5.18. I would normally be super against, but if it really didn't work before, then there's no point blindly following the rules if the u

D27061: replace samba module with data that works

sitter updated this revision to Diff 75170. sitter added a comment. move from qmap to straight up qlist as values() within the map wouldn't necessarily have the expected order. instead find_by udi on add/remove and rely on index within the list the rest of the time additional qa: have 2

D27061: replace samba module with data that works

jriddell added a comment. As release mangler for Plasma I'd normally point out this is a breach of feature freeze, but it seems to have the support of important Plasma people so great go ahead when ready. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27061 To

D27061: replace samba module with data that works

davidedmundson added inline comments. INLINE COMMENTS > smbmountmodel.cpp:73 > +case ColumnRole::Share: > +return > devices().at(index.row()).as()->url(); > +case ColumnRole::Path: This looks dangerous. You always add row indexes to the end, but you're taking an ind

D27061: replace samba module with data that works

ltoscano added a comment. As no one else complained, and given the general brokeness of the current code, I'd say: please go for it. 5.18.0 is already tagged, there are ~11 days before 5.18.1 (planned for Tue 11th) and ~18 before 5.18.2, so we will probably catch up. +1 from the localiz

D27061: replace samba module with data that works

ngraham added a comment. #localization folks, can we get an approval or rejection for this? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27061 To: sitter, #localization, #plasma, #vdg Cc: yurchor, ngraham, alexd

D27061: replace samba module with data that works

sitter updated this revision to Diff 74992. sitter added a comment. typo-- REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27061?vs=74764&id=74992 BRANCH smb REVISION DETAIL https://phabricator.kde.org/D27061 AFFECTED FILES LICENSES/GPL-2.0-only

D27061: replace samba module with data that works

yurchor added a comment. Thanks in advance for fixing these minor typos. INLINE COMMENTS > main.cpp:65 > +auto title = new KTitleWidget(this); > +// hackily remove ampersand to not break i18n too too much in 5.18 > +// TODO: replace i18n'd string to one without quick access marker

D27061: replace samba module with data that works

sitter added a comment. I was trying to recycle as many strings as possible. If the localizers are fine with us throwing caution to the wind for those two strings as well then that's fine with me naturally, it would also allow me to get rid of a naughty hack I had to pull to retain the strin

D27061: replace samba module with data that works

ngraham added reviewers: Localization, Plasma, VDG. ngraham added a comment. Very nice. Looks much better and seems to work quite well. While we're already breaking proposing breaking the string freeze, instead of "Exports" and "Imports", how about "Exported Shares" and "Mounted shares" o

D27061: replace samba module with data that works

sitter updated this revision to Diff 74764. sitter added a comment. translate accessible bool to icons + resize its column. looks better and avoids yet more new strings REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27061?vs=74762&id=74764 BRANCH sm

D27061: replace samba module with data that works

sitter updated this revision to Diff 74762. sitter added a comment. unbreak model actually REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27061?vs=74761&id=74762 BRANCH smb REVISION DETAIL https://phabricator.kde.org/D27061 AFFECTED FILES LICEN

D27061: replace samba module with data that works

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY ... and doesn't require lots of maintenance! this targets 5.18 but is kind of unfortunate because it needs a bunch of new strings