D27023: Port to UpdateLaunchEnvJob

davidedmundson added a comment. We haven't called start on any of the jobs, so they do nothing :/ Also given they're kjobs do we want: auto job = new UpdateEnvJob() so we don't delete the job immediately? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.

D27023: Port to UpdateLaunchEnvJob

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9e3fd9215245: Port to UpdateLaunchEnvJob (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27023?vs=74666&id=74670 REVISION DETAIL htt

D27023: Port to UpdateLaunchEnvJob

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in krdb.cpp:39-40 > I don't understand why this changes I don't either but it wouldn't build without. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27023 To: broulik, #plasma, davidedmundso

D27023: Port to UpdateLaunchEnvJob

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Beautiful. I suspect this will fix a few bugs whilst we're at it. There were a lot running after startplasma has started, so wouldn't have been synced properly to the

D27023: Port to UpdateLaunchEnvJob

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Depends on D26993 REPOSITORY R119 Plasma Desktop REVISION DETAIL