This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:0aa162f2e838: Remove export header from static install
(authored by masonm, committed by jbbgameich).
REPOSITORY
R16
jbbgameich added a comment.
@apol is your question answered now / can I land this?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D26956
To: masonm, #kirigami, mart, apol
Cc: jbbgameich, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham,
apol, ahiemstr
masonm requested review of this revision.
masonm added a comment.
Hello,
Just following up on this change review—it all looks good to me. Can we merge
it in?
Thanks!
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D26956
To: masonm, #kirigami, mart, apol
C
masonm added a comment.
It appears all the sources which reference the export header have an
appropriate guard on them:
#ifndef KIRIGAMI_BUILD_TYPE_STATIC
#include
#endif
I found these in tabletmodewatcher.h, kirigamipluginfactory.h, platformtheme.h
REPOSITORY
R169 Kirigami
masonm added a comment.
Ah, I'll take a closer look.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D26956
To: masonm, #kirigami, mart, apol
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,
ahiemstra, davidedmundson, mart, hein
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.
Wait no, are you sure? kirigami headers will still include the file...
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D26956
To: masonm, #kirigami, mart, ap
masonm created this revision.
masonm added a reviewer: VDG.
masonm added a project: Kirigami.
Herald added a subscriber: plasma-devel.
masonm requested review of this revision.
REVISION SUMMARY
When building the "install" target with a static Kirigami build an error
occurs due to the missing fi
