sitter added inline comments.
INLINE COMMENTS
> context.cpp:600
>
> +void Context::loadModule(const QString &name, const QString &argument)
> +{
Should this maybe return a bool? If the operation as a whole fails it seems
that should be reflected somehow. Or does this emit an error via event
bshah updated this revision to Diff 74417.
bshah added a comment.
add ::unloadModule which takes Module* parameter
REPOSITORY
R994 Pulseaudio Qt Bindings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26935?vs=74414&id=74417
BRANCH
add-load-unload-module
REVISION DETAIL
http
bshah added a comment.
> unloadModule should work with a Module* given the rest of the API deals
with them rather than their index I think
Yes, it does indeed make sense, maybe I can add a another signature of
unloadModule which takes Module* as argument.
> I was about to say someth
bshah created this revision.
bshah added reviewers: sitter, nicolasfella.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
Current usecase is dialer wanting to load the loopback modules
during runtime.
REPOSITOR
nicolasfella added a comment.
I was about to say something similar. Where would one get the index from?
REPOSITORY
R994 Pulseaudio Qt Bindings
REVISION DETAIL
https://phabricator.kde.org/D26935
To: bshah, sitter, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh
sitter added a comment.
unloadModule should work with a Module* given the rest of the API deals with
them rather than their index I think
REPOSITORY
R994 Pulseaudio Qt Bindings
REVISION DETAIL
https://phabricator.kde.org/D26935
To: bshah, sitter, nicolasfella
Cc: plasma-devel, Orage, Le
