D26923: Fix systemtray configuration

2020-03-13 Thread Allan Sandfeld Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R120:ce69fc4ea914: Fix systemtray configuration (authored by carewolf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26923?vs=74379&id=77568 REVISION DETAIL

D26923: Fix systemtray configuration

2020-01-26 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. @konrad you're part of the kde team now. Feel free to approve things you're comfortable with. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL htt

D26923: Fix systemtray configuration

2020-01-26 Thread Konrad Materka
kmaterka added a comment. Look good for me, but someone else from KDE team needs to approve this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26923 To: carewolf, #plasma_workspaces, davidedmundson Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-O

D26923: Fix systemtray configuration

2020-01-26 Thread Allan Sandfeld Jensen
carewolf updated this revision to Diff 74379. carewolf added a comment. Changed name of property instead REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26923?vs=74378&id=74379 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D26

D26923: Fix systemtray configuration

2020-01-26 Thread Konrad Materka
kmaterka added a comment. Thanks for noticing! The `currentValue` property was introduced with QtQuick.Controls 2.14 (Qt 5.14). Very convenient, unfortunately Plasma 5.18 must support Qt 5.12. BTW. QML import

D26923: Fix systemtray configuration

2020-01-26 Thread Allan Sandfeld Jensen
carewolf created this revision. carewolf added reviewers: Plasma: Workspaces, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carewolf requested review of this revision. REVISION SUMMARY The property currentValue is conflicting making the qml file not run