D26896: Kill the KinfoCenter binary

2020-01-28 Thread Johnny Jazeix
jjazeix added inline comments. INLINE COMMENTS > CMakeLists.txt:85 > -configure_file(config-project-version.h.cmake > ${CMAKE_CURRENT_BINARY_DIR}/config-project-version.h) > -configure_file(config-X11.h.cmake ${CMAKE_CURRENT_BINARY_DIR}/config-X11.h) > include_directories(${CMAKE_CURRENT_BINARY

D26896: Kill the KinfoCenter binary

2020-01-28 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R102:24f4c6f97875: Kill the KinfoCenter binary (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26896?vs=74434&id=74493#toc REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDAT

D26896: Kill the KinfoCenter binary

2020-01-28 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:106 > + > +ADD_CUSTOM_TARGET(kinfocenter_link ALL > + COMMAND ${CMAKE_COMMAND} -E create_symlink > ${KDE_INSTALL_FULL_BI

D26896: Kill the KinfoCenter binary

2020-01-27 Thread Marco Martin
mart updated this revision to Diff 74434. mart added a comment. - back to kinfocenter bin name REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74433&id=74434 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D26896 A

D26896: Kill the KinfoCenter binary

2020-01-27 Thread Marco Martin
mart updated this revision to Diff 74433. mart added a comment. - link kinfocenter to systemsettings5 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26896?vs=74308&id=74433 BRANCH mart/kinfoCenterMode REVISION DETAIL https://phabricator.kde.org/D2

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Nathaniel Graham
ngraham added a comment. In D26896#600258 , @broulik wrote: > Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? > Does it still show up if you type "kinfocenter" into KRunner, not sure if

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Kai Uwe Broulik
broulik added a comment. Would it make sense to keep a `kinfocenter` script that just launchers `systemsettings5 -i` for compat? Does it still show up if you type "kinfocenter" into KRunner, not sure if it uses the `Exec` for that if this name is in the desktop file somewhere other than th

D26896: Kill the KinfoCenter binary

2020-01-24 Thread David Edmundson
davidedmundson added a comment. Assuming the other gets in, ship it! INLINE COMMENTS > CMakeLists.txt:25 > Crash > DBusAddons > DocTools We can probably get rid of at least this. Maybe quite a few others REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde

D26896: Kill the KinfoCenter binary

2020-01-24 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Remove the binary, only install the modules and categories. The categories have been reorganized a bit to