D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R99:66ab37df7aed: Bind gtk-enable-animations setting to global animation speed slider (authored by broulik). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-23 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74203. broulik added a comment. - Fix typos REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74193&id=74203 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/configedi

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-23 Thread Mikhail Zolotukhin
gikari added a comment. Some typos, without them everything is OK. INLINE COMMENTS > configeditor.cpp:173 > QStringLiteral("gtk-primary-button-warps-slider"), > +QStringLiteral("enable-animations"), > }; You have a typo. The correct name of the parameter is "__gtk-__en

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-23 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74193. REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74115&id=74193 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/configeditor.cpp kded/configeditor.h kded/conf

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Mikhail Zolotukhin
gikari added a comment. Also i found out, that gtk apps on start throw this error: (org.gnome.Nautilus:4278): Gdk-WARNING **: 21:08:58.246: Cannot transform xsetting gtk-enable-animations of type gchararray to type gboolean This is because of xsettingd config. You need to add `Gtk/

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Nathaniel Graham
ngraham added a comment. +1 for putting this in 5.18 once @gikari thinks it's ready. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26825 To: broulik, #plasma, gikari Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, j

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Mikhail Zolotukhin
gikari requested changes to this revision. gikari added a comment. This revision now requires changes to proceed. Seems like dconf does not convert !!string!! to !!boolean!!. (process:24285): GLib-GIO-CRITICAL **: 17:51:47.492: g_settings_set_value: key 'enable-animations' in 'org.gnome

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74115. broulik added a comment. - Drop pointless argument REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74108&id=74115 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Mikhail Zolotukhin
gikari added inline comments. INLINE COMMENTS > gtkconfig.cpp:189 > + > ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-enable-animations"), > enableAnimations); > + > ConfigEditor::setGtk3ConfigValueDconf(QStringLiteral("enable-animations"), > enableAnimations, QStringLiteral("org

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74108. broulik added a comment. - Drop superfluous `reparseConfiguration` call REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74094&id=74108 REVISION DETAIL https://phabricator.kde.org/D268

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in configvalueprovider.cpp:146 > You don't need this. > > KConfigWatcher does it automagically on change. > > I did that because I wanted a way for N connections to only reparse the file > once. It also means you can use the

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > configvalueprovider.cpp:146 > +{ > +ownConfig->reparseConfiguration(); > +KConfigGroup generalCfg = ownConfig->group(QStringLiteral("KDE")); You don't need this. KConfigWatcher does it automagically on change. I did that because I

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74094. broulik added a comment. - Fix settings key REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74080&id=74094 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/co

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Mikhail Zolotukhin
gikari added inline comments. INLINE COMMENTS > gtkconfig.cpp:188 > +const QString enableAnimations = configValueProvider->enableAnimations(); > +ConfigEditor::setGtk2ConfigValue(QStringLiteral("gtk-button-images"), > enableAnimations); > + > ConfigEditor::setGtk3ConfigValueDconf(QSt

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik updated this revision to Diff 74080. broulik added a comment. - Add GTK2 key REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26825?vs=74077&id=74080 REVISION DETAIL https://phabricator.kde.org/D26825 AFFECTED FILES kded/config

D26825: Bind gtk-enable-animations setting to global animation speed slider

2020-01-22 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, gikari. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When it is set to "Instant", turn off GTK animations. TEST PLAN - Started gedit, clicked