alex abandoned this revision.
alex added a comment.
Abandoning this, because there have been a few patches to the same kcm and
this is mostly formatting.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26799
To: alex, ngraham, meven, davidedmundson
Cc: davide
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
emit and Q_EMIT are the same thing, I wouldn't change any future instances
Q_EMIT has the advantage of not conflicting with some other libraries like
emit sometimes can
alex marked an inline comment as done.
alex added inline comments.
INLINE COMMENTS
> meven wrote in filteredfoldermodel.cpp:38
> space ? I am not sure.
I am not sure too, because in the plasma-workspace project and even some qt
files it is sometimes formatted like above but sometimes it is inde
alex updated this revision to Diff 73988.
alex added a comment.
Add parentheses for parameter list
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26799?vs=73987&id=73988
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26799
AFFECTED
alex updated this revision to Diff 73987.
alex added a comment.
Adjust formatting of lambdas
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26799?vs=73980&id=73987
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26799
AFFECTED FILES
meven added a comment.
Nice changes.
INLINE COMMENTS
> filteredfoldermodel.cpp:38
> +{
> +QStringList addTrailingSlashes(const QStringList &input)
> +{
space ? I am not sure.
> kcm.cpp:44
> {
> -QStringList defaultFolders()
> -{
> -return { QDir::homePath() };
> -}
> +i
alex created this revision.
alex added reviewers: ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The affected files have been reformatted following the KDE coding style (this
makes up most of the
