D26760: Update from Plasma for ToolTipInstance.qml

This revision was automatically updated to reflect the committed changes. Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=74260&id=74296 REVISION DE

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. I would prefer to be separate commits. Please commit this one and we can discuss in upcoming commit the highlight changes REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL https://phabricator.kde.org/

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 to be committed, then I will add it to this patch. It looks pretty nice. :) REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL h

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#599227 , @mvourlakos wrote: > @trmdi have you checked the previews still work OK after the patch? Yes, I tested it. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To:

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 74260. trmdi added a comment. - Address comment REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73935&id=74260 BRANCH update-ToolTipInstance-fromPlasma (branched from master) REVISION DETAIL https://phabr

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. @trmdi have you checked the previews still work OK after the patch? INLINE COMMENTS > ToolTipInstance.qml:159 > Layout.alignment: Qt.AlignRight | Qt.AlignTop > - > -height: units.iconSizes.smallMedium > -width: height > - > -

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added inline comments. INLINE COMMENTS > ToolTipInstance.qml:175 > // round necessary, otherwise shadow mask for players has gap! > -height: Math.round(0.5 * width) + (!winTitle.visible? > winTitle.height : 0) > +height: Math.round(0.5 * width) + (!winTitle.visible

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73935. trmdi added a comment. - hasPlayer-tooltips shouldn't disappear when the mouse is inside the bottom margin of the tooltip REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73876&id=73935 BRANCH update-

D26760: Update from Plasma for ToolTipInstance.qml

trmdi updated this revision to Diff 73876. trmdi added a comment. - Add https://phabricator.kde.org/D11025 REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26760?vs=73861&id=73876 BRANCH update-ToolTipInstance-fromPlasma REVISION DETAIL https://phabr

D26760: Update from Plasma for ToolTipInstance.qml

trmdi added a comment. In D26760#596760 , @mvourlakos wrote: > Is there any improvement, or it is just a code update? Some minor improvements: - https://phabricator.kde.org/D22230 - https://phabricator.kde.org/D21629 REPOSITORY

D26760: Update from Plasma for ToolTipInstance.qml

mvourlakos added a comment. Is there any improvement, or it is just a code update? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26760 To: trmdi, #latte_dock Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26760: Update from Plasma

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Just pull the update from Plasma REPOSITORY R878 Latte Dock BRANCH update-ToolTipInstance-from