sitter updated this revision to Diff 74131.
sitter added a comment.
get delay from qstyle
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26733?vs=73784&id=74131
BRANCH
delay
REVISION DETAIL
https://phabricator.kde.org/D26733
AFFECTED FILES
Tool
sitter added a comment.
I suppose. That is not what systemsettings does though.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D26733
To: sitter, mart
Cc: mart, ngraham, bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,
jraleigh, zachus, fbampaloukas,
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
couldn't this just use the standard delay set by the style?
QStyle::SH_ToolTip_WakeUpDelay
REPOSITORY
R102 KInfoCenter
BRANCH
delay
REVISION DETAIL
https://phabricator.kde.org/D2673
ngraham added a comment.
Yeah, it might be nice to extract this into a framework that can bee used by
all three apps so it can't diverge this way again.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D26733
To: sitter
Cc: ngraham, bcooksley, plasma-devel, LeGast
sitter added a comment.
ugh :(
Thanks for context though.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D26733
To: sitter
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,
bcooksley added a comment.
The code if memory serves originates from Dolphin, it was copied from there
into System Settings (which was done by me - we weren't sure about API
stability at the time for upstreaming to kdelibs as it was at the time), and
then must have been copied again from the
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.
REVISION SUMMARY
50 is fairly short, 300 as used in systemsettings is much nicer
and also makes the two uis behave the same
BUG: 393722
FIXED-
