D26714: KCM/Component Revamp FileManager UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2e54c4e748ba: KCM/Component Revamp FileManager UI (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73962&id=73963 REVISION DETAI

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73962. meven added a comment. Add copyright mention, add icon for added terminal emulator REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73951&id=73962 BRANCH filemanager-settings REVISION DETAIL htt

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73951. meven added a comment. Fix: Save the newly saved selected filemanager in m_currentIndex REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73946&id=73951 BRANCH filemanager-settings REVISION DETAIL

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73946. meven added a comment. Correct comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73746&id=73946 BRANCH filemanager-settings REVISION DETAIL https://phabricator.kde.org/D26714 AFFECTED FI

D26714: KCM/Component Revamp FileManager UI

meven added inline comments. INLINE COMMENTS > componentchooserfilemanager.cpp:116 > + > +// add a other option to add a new file manager with keditfiletype5 > + > combofileManager->addItem(QIcon::fromTheme(QStringLiteral("application-x-shellscript")), > i18n("Other..."), QStringLiteral(

D26714: KCM/Component Revamp FileManager UI

meven updated this revision to Diff 73746. meven added a comment. Use KOpenWithDialog instead of keditfiletype5 to select the filemanager + small fix REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26714?vs=73731&id=73746 BRANCH filemanager-settin

D26714: KCM/Component Revamp FileManager UI

meven planned changes to this revision. meven added a comment. In D26714#595786 , @ngraham wrote: > Selecting the "Other..." option for this one takes me to the filetype editor for `inode/directory` instead of the app chooser as in the other pat

D26714: KCM/Component Revamp FileManager UI

ngraham added a comment. Selecting the "Other..." option for this one takes me to the filetype editor for `inode/directory` instead of the app chooser as in the other patches. Is that intentional? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26714 To: mev

D26714: KCM/Component Revamp FileManager UI

meven created this revision. meven added reviewers: Plasma, ervin, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH filemanager-settings REVISION DETAIL https://phabricator.kde.o