This revision was automatically updated to reflect the committed changes.
Closed by commit R119:4a0ba9e02697: KCM/Component Revamp Terminal Emulator UI
(authored by meven).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26705?vs=73950&id=73960
REVISION
meven updated this revision to Diff 73950.
meven added a comment.
Fix: Save the newly saved selected terminal emulator in m_currentIndex
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26705?vs=73949&id=73950
BRANCH
terminal-config
REVISION DETAIL
meven updated this revision to Diff 73949.
meven marked 3 inline comments as done.
meven added a comment.
Fix formatting, remove a bad Q_UNUSED
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26705?vs=73750&id=73949
BRANCH
terminal-config
REVISION
ervin added inline comments.
INLINE COMMENTS
> componentchooserterminal.cpp:46
>
> -void CfgTerminalEmulator::configChanged()
> -{
> - emit changed(true);
> +void CfgTerminalEmulator::selectTerminalEmulator(int index) {
> +Q_UNUSED(index)
Curly brace should be on its own line
> compon
meven added inline comments.
INLINE COMMENTS
> componentchooserterminal.cpp:47
> +void CfgTerminalEmulator::selectTerminalEmulator(int index) {
> +Q_UNUSED(index)
> +
remove
REPOSITORY
R119 Plasma Desktop
BRANCH
terminal-config
REVISION DETAIL
https://phabricator.kde.org/D26705
To:
meven updated this revision to Diff 73750.
meven added a comment.
Clean two bad lines
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26705?vs=73718&id=73750
BRANCH
terminal-config
REVISION DETAIL
https://phabricator.kde.org/D26705
AFFECTED FIL
meven added inline comments.
INLINE COMMENTS
> componentchooserterminal.cpp:138
> +changed(index != m_currentIndex);
> +m_currentIndex = terminalCombo->currentIndex();
> +} else {
Remove
> componentchooserterminal.cpp:143
> +terminalCombo->setCurrentIndex(terminalCom
meven updated this revision to Diff 73718.
meven marked an inline comment as done.
meven edited the test plan for this revision.
meven added a comment.
NoDisplay == false instead of NoDisplay != true
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D267
ngraham accepted this revision.
ngraham added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> componentchooserterminal.cpp:76
> +
> +const auto constraint = QStringLiteral("'TerminalEmulator' in Categories
> AND (not exist NoDisplay OR NoDisplay != true)")
meven created this revision.
meven added reviewers: Plasma, ervin, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
Revamp UI, to use a simple combobox
- Other... choice allows to select any programe
10 matches
Mail list logo
