This revision was automatically updated to reflect the committed changes.
Closed by commit R114:a51086867c0f: [applets/calculator] Use Qt's in-built
number formatting (authored by davidedmundson).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26676?vs=7
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Can confirm that it fixes the bug, and the code change looks sane to me.
REPOSITORY
R114 Plasma Addons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26676
To: davided
ngraham added a reviewer: VDG.
ngraham added a comment.
> Potentially this inadvertedly introduces a behaviour change
> of including group separators depending on locale.
> Is this a a good feature?
I can't speak for everyone, but personally I like seeing the localized
separators as
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Gets rid of a load of code.
Correctly handles floating point issues.
Res
