This revision was automatically updated to reflect the committed changes.
Closed by commit R124:01cecb1602aa: ModuleView: Hide button when KCModule
don't need them (authored by bport).
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26518?vs=73043&id=73
ervin accepted this revision.
ervin added a comment.
Doesn't quite make sense to both hide and disable, but no big deal.
INLINE COMMENTS
> ervin wrote in ModuleView.cpp:398
> Nope, see my comment on the other patch :-)
Alright, I'll contradict myself, the doc claimed the contrary forever.
R
ervin added inline comments.
INLINE COMMENTS
> meven wrote in ModuleView.cpp:398
> `d->mHelp->setVisible(buttons & KCModule::Help )` ?
Nope, see my comment on the other patch :-)
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D26518
To: bport, ervin, meven, cr
bport updated this revision to Diff 73043.
bport added a comment.
Set visibility for help too
REPOSITORY
R124 System Settings
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26518?vs=73041&id=73043
REVISION DETAIL
https://phabricator.kde.org/D26518
AFFECTED FILES
core/ModuleV
meven added inline comments.
INLINE COMMENTS
> ModuleView.cpp:398
> +d->mReset->setVisible(buttons & KCModule::Apply);
> d->mHelp->setEnabled(buttons & KCModule::Help );
> emit moduleChanged( change );
`d->mHelp->setVisible(buttons & KCModule::Help )` ?
REPOSITORY
R124 System Se
bport created this revision.
bport added reviewers: ervin, meven, crossi, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D26518
AFFEC
