D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#591264 , @mart wrote: > needed probably a graphical way to make it obvious that this will trigger on release rather than just showing the action Yes, exactly REPOSITORY R169 Kirigami REVISION DETAIL

D26354: Introduce ActionRow widget

mart added a comment. In D26354#590841 , @ngraham wrote: > In D26354#590815 , @mart wrote: > > > SwipeListItem should just trigger when there is only one action, really (and that one doesn't conflict

D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#590815 , @mart wrote: > SwipeListItem should just trigger when there is only one action, really (and that one doesn't conflict because the swipe is from the screen edge) Hey yeah, that could work. REPOS

D26354: Introduce ActionRow widget

mart added a comment. In D26354#589642 , @ngraham wrote: > In D26354#589352 , @mart wrote: > > > also a component like that back then was chosen to not be added by purpose in part because gesture-wis

D26354: Introduce ActionRow widget

ngraham added a comment. In D26354#589352 , @mart wrote: > also a component like that back then was chosen to not be added by purpose in part because gesture-wise conflicts with the navigate back of pagerow Personally I don't find Kirigam

D26354: Introduce ActionRow widget

mart added a comment. my gripe is that is a lot of javascript which could be simply implemented with a swipedelegate, having less heavy javascript which is a serious problem when used in delegates. also a component like that back then was chosen to not be added by purpose in part becaus

D26354: Introduce ActionRow widget

ouwerkerk added a comment. Are we certain about naming here: `SwipeAction.isDelete`? Maybe `SwipeAction.remove` or `SwipeAction.removeFromList` ? It doesn't necessarily have to be a real "delete" action that is backing this, maybe all you want to convey with the name of this setting is that

D26354: Introduce ActionRow widget

cblack updated this revision to Diff 72580. cblack added a comment. Get the other two items unhardcoded REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26354?vs=72579&id=72580 BRANCH actionrow (branched from master) REVISION DETAIL https://phabricator

D26354: Introduce ActionRow widget

cblack updated this revision to Diff 72579. cblack marked an inline comment as done. cblack added a comment. Update based off of feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26354?vs=72578&id=72579 BRANCH actionrow (branched from master) REV

D26354: Introduce ActionRow widget

ngraham added inline comments. INLINE COMMENTS > ActionRow.qml:51 > + > +height: 64 > + Make this a multiple of GridUnit > ActionRow.qml:144 > +anchors.left: parent.left > +anchors.leftMargin: 20 > +anchors.verticalCenter: parent.verticalCente

D26354: Introduce ActionRow widget

cblack created this revision. cblack added reviewers: VDG, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY ActionRows are row widgets with associated actions. Left and right actions are triggered by