ouwerkerk abandoned this revision.
ouwerkerk added a comment.
Superseded by: https://phabricator.kde.org/D26367
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26344
To: ouwerkerk, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-
ouwerkerk added a comment.
Right now the KCM CmakeListst does stuff like:
set(kcm_lookandfeel_SRCS
kcmmain.cpp
kcm.cpp
../krdb/krdb.cpp
../cursortheme/xcursor/cursortheme.cpp
../cursortheme/xcursor/xcursortheme.cpp
)
And the main `kcm.cpp` simply in
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
That may fix the build, but it's a somewhat hamfisted approach, lookandfeel
is a key KCM, we can't make that depend on an optional feature.
We need to either:
ouwerkerk updated this revision to Diff 72544.
ouwerkerk added a comment.
Fixed commit message typo
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26344?vs=72542&id=72544
BRANCH
fix-build-without-cursors
REVISION DETAIL
https://phabricator.kde.
ouwerkerk created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.
REVISION SUMMARY
The lookandfeel KCM has a hard dependency on xcursor code of the cursor KCM.
This change updates the CMake code to reflect thi
