D26238: Improve context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R878:fe5dbf9f2b96: Improve context menu (authored by trmdi). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72253&id=72255 REVISION DETAIL https://phabrica

D26238: Improve context menu

mvourlakos added a comment. In D26238#583563 , @trmdi wrote: > In D26238#583556 , @mvourlakos wrote: > > > In D26238#583555 , @trmdi wrote: > > > > > I

D26238: Improve context menu

trmdi added a comment. In D26238#583556 , @mvourlakos wrote: > In D26238#583555 , @trmdi wrote: > > > In D26238#583551 , @mvourlakos wrote: > > > > > @

D26238: Improve context menu

trmdi updated this revision to Diff 72253. trmdi added a comment. - Change icon of the configure action REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72246&id=72253 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTE

D26238: Improve context menu

mvourlakos added a comment. In D26238#583555 , @trmdi wrote: > In D26238#583551 , @mvourlakos wrote: > > > @trmdi I used Cuttlefish app, it points to **"edit"** > > > Maybe it's `document-edit`

D26238: Improve context menu

trmdi added a comment. In D26238#583551 , @mvourlakos wrote: > @trmdi I used Cuttlefish app, it points to **"edit"** Maybe it's `document-edit`. (See this: https://api.kde.org/frameworks/plasma-framework/html/containment_8cpp_source.ht

D26238: Improve context menu

mvourlakos added a comment. @trmdi I used Cuttlefish app, it points to **"edit"** REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ngraham, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jralei

D26238: Improve context menu

mvourlakos added a subscriber: ngraham. mvourlakos added a comment. In D26238#583529 , @trmdi wrote: > In D26238#583386 , @ndavis wrote: > > > This seems inconsistent with the Plasma panel context men

D26238: Improve context menu

trmdi added a comment. In D26238#583386 , @ndavis wrote: > This seems inconsistent with the Plasma panel context menu: F7844566: Screenshot_20191227_000605.png Do you know what icon is used for the "

D26238: Improve context menu

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. looks ok... I am not that fond of the second line separator but we can discuss this again in the future. REPOSITORY R878 Latte Dock BRANCH master REVISION DETAIL https:

D26238: Improve context menu

trmdi added a comment. In D26238#583520 , @mvourlakos wrote: > look ok! Can you please provide also the three screenshots mentioned earlier for reference? Done. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org

D26238: Improve context menu

mvourlakos added a comment. look ok! Can you please provide also the three screenshots mentioned earlier for reference? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-O

D26238: Improve context menu

trmdi updated this revision to Diff 72246. trmdi added a comment. - Typo REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72244&id=72246 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTED FILES app/layouts/manager.c

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.h:114 > void hideLatteSettingsDialog(); > -Q_INVOKABLE void showLatteSettingsDialog(int page = > Latte::Types::LayoutPage); > +Q_INVOKABLE void showLatteSettingsDialog(int firstPage = > Latte::Types::LayoutPage, bool toogl

D26238: Improve context menu

trmdi updated this revision to Diff 72244. trmdi added a comment. - Call toggleCurrentPage() only when using the shortcut REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72238&id=72244 BRANCH master REVISION DETAIL https://phabricator.kde.o

D26238: Improve context menu

mvourlakos added a comment. @trmdi based on your last commit: 1. you have made all showLatteSettingsDialog callers as togglers, meaning that : IF Latte Layouts manager is already shown and the user tries Layouts->Manage Layouts then the settings tab will switch to Latte Preferences wind

D26238: Improve context menu

trmdi updated this revision to Diff 72238. trmdi added a comment. - Address comments REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72228&id=72238 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26238 AFFECTED FILES app/layou

D26238: Improve context menu

mvourlakos added inline comments. INLINE COMMENTS > manager.cpp:419 > > void Manager::showLatteSettingsDialog(int page) > { We could try to rename the function to: void Manager::showLatteSettingsDialog(int firstPage, bool cycleBetweenPages = false) when cycleBetweenPages = true then the

D26238: Improve context menu

mvourlakos added a comment. In D26238#583413 , @trmdi wrote: > 1. It still works for other cases. Do you cycle in settings tabs with Meta+W, between Layouts and Preferences ? > 3. "Configure Application" sounds a bit unclearly. And i

D26238: Improve context menu

trmdi added a comment. 4. I want to separate between **View's items** (Add widget, Edit View) and **Latte's items** (Layouts, Configure Latte) because they are two different groups. REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #v

D26238: Improve context menu

trmdi added a comment. 1. It still works for other cases. 3. "Configure Application" sounds a bit unclearly. And it can confuse users with "Configure Application Dashboard". "Configure Latte Global Settings..." is too long? REPOSITORY R878 Latte Dock REVISION DETAIL https://ph

D26238: Improve context menu

mvourlakos added a comment. the [Verb+Noun] sounds logical, updated names in my last comment REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg, mvourlakos Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fb

D26238: Improve context menu

mvourlakos added a comment. This commit needs to be split in different commits. Based on the approach I wil describe the issues of the commit and in what changes I can approve or not. SPLITTED COMMITS 1. The showLatteSettingsDialog() is used from more places and you have changed i

D26238: Improve context menu

trmdi updated this revision to Diff 72228. trmdi added a comment. - Add a new separator and change addWidget's icon REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26238?vs=72227&id=72228 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26

D26238: Improve context menu

ndavis added a comment. In D26238#583390 , @trmdi wrote: > In D26238#583389 , @ndavis wrote: > > > In the plasma panel context menu, add widgets and edit panel are below the separator > > > May

D26238: Improve context menu

trmdi added a comment. In D26238#583389 , @ndavis wrote: > In the plasma panel context menu, add widgets and edit panel are below the separator Maybe I need to create a new separator at the line 126 instead of reusing it. What about the

D26238: Improve context menu

ndavis added a comment. In the plasma panel context menu, add widgets and edit panel are below the separator REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus

D26238: Improve context menu

ndavis added a comment. This seems inconsistent with the Plasma panel context menu: F7844566: Screenshot_20191227_000605.png REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D26238 To: trmdi, #latte_dock, #vdg Cc: ndavis, plas

D26238: Improve context menu

trmdi created this revision. trmdi added reviewers: Latte Dock, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Merge branch 'master' of https://anongit.kde.org/latte-dock REPOSITORY R878 Latte Dock BRANC