This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d21cb2e7a95b: Add byte display option in Network Monitor
plasmoid (authored by gvgeo, committed by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
ngraham added a comment.
Lovely contribution, thanks very much!
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26124
To: gvgeo, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,
fbampaloukas,
gvgeo updated this revision to Diff 71926.
gvgeo added a comment.
Correct label of displayUnits in xml.
Add values to displayUints options.
Correct copyright message.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26124?vs=71921&id=71926
BRANC
ngraham added a comment.
Even nicer. :)
INLINE COMMENTS
> main.xml:22
> +
> +1
> +
an inline comment documenting what the ints map to would be nice
> displayConfig.qml:2
> +/*
> + * Copyright 2015 Marco Martin
> + *
Your copyright
REPOSITORY
R120 Plasma Workspace
gvgeo updated this revision to Diff 71921.
gvgeo added a comment.
Add xml display entry, to save the option.
Added in the common main.xml. Now the rest 4 system monitor applets
will have an extra entry that will not use.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
http
ngraham accepted this revision as: VDG.
ngraham added a reviewer: Plasma.
ngraham added a comment.
Nice clean QML and a reasonable UI.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26124
To: gvgeo, #vdg, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Fe
gvgeo added a comment.
I can't find a way to add the new option in the same Interfaces group.
If I add Kirigami.FormLayout stops reading the values, even if the layout
works.
Tried something like this:
Kirigami.FormLayout { //
gvgeo created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.
REVISION SUMMARY
Add the option to select between byte and bit display in Network Monitor
plasmoid.
Bug: 383019
REPOSITORY
R120 Plasma Workspace
B
