D26094: Add shadow rendering helper functions

2019-12-19 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R31:4a78561a3ae6: Add shadow rendering helper functions (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71845&id=71846 REVISION DETAIL htt

D26094: Add shadow rendering helper functions

2019-12-19 Thread Noah Davis
ndavis updated this revision to Diff 71845. ndavis added a comment. Update ellipse shadow comment again and rounded rect shadow parameter name REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71825&id=71845 BRANCH replace-hardcoded (branched from ma

D26094: Add shadow rendering helper functions

2019-12-19 Thread Hugo Pereira Da Costa
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Looks good and sensible. Very nice consolidation. Thanks ! REPOSITORY R31 Breeze BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator

D26094: Add shadow rendering helper functions

2019-12-19 Thread Nathaniel Graham
ngraham added a comment. Very nice! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26094 To: ndavis, #breeze, hpereiradacosta, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D26094: Add shadow rendering helper functions

2019-12-18 Thread Noah Davis
ndavis updated this revision to Diff 71825. ndavis added a comment. Edit ellipse shadow comment REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26094?vs=71824&id=71825 BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator.kd

D26094: Add shadow rendering helper functions

2019-12-18 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This patch makes other helper functions reuse more code by calling these shadow rendering functions