volkov added inline comments.
INLINE COMMENTS
> control.cpp:266
> +const auto val = info[QStringLiteral("autorotate")];
> +return !val.canConvert() || val.toBool();
> +}
Why treat an inconvertible value as true and not false?
REPOSITORY
R104 KScreen
REVISION D
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:6ac5ae0822c4: feat: add Control API for auto rotation
(authored by romangg).
REPOSITORY
R104 KScreen
CHANGES SINCE
romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.
REVISION SUMMARY
With this API the current user preference for auto rotation a particular
output
on global level