D25846: [Cuttlefish] Use the same actions in all menus

This revision was automatically updated to reflect the committed changes. Closed by commit R118:6e3f467ad266: [Cuttlefish] Use the same actions in all menus (authored by davidre). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25846?vs=71255&id=71282 REVIS

D25846: [Cuttlefish] Use the same actions in all menus

davidre added inline comments. INLINE COMMENTS > Menu.qml:24 > > -import QtQuick 2.5 > -import Qt.labs.platform 1.0 > +import QtQuick 2.3 > +import QtQuick.Controls 2.5 as QQC2 Sorry that came from the copy-pasting from Kirigami > Menu.qml:47 > +property Component submenuComponent

D25846: [Cuttlefish] Use the same actions in all menus

davidre updated this revision to Diff 71255. davidre marked 2 inline comments as done. davidre added a comment. Comments REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25846?vs=71193&id=71255 BRANCH actions (branched from master) REVISION DETAIL ht

D25846: [Cuttlefish] Use the same actions in all menus

ngraham added a comment. Nice, a very good refactor. INLINE COMMENTS > Menu.qml:24 > > -import QtQuick 2.5 > -import Qt.labs.platform 1.0 > +import QtQuick 2.3 > +import QtQuick.Controls 2.5 as QQC2 unrelated > Menu.qml:47 > +property Component submenuComponent: actionsMenu >

D25846: [Cuttlefish] Use the same actions in all menus

davidre created this revision. davidre added reviewers: Plasma, ngraham, cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Defines the actions in one place and uses them for the context menus and buttons