sniperrifle added a comment.
I'm thinking of adding what the intended behaviour is of the function
regarding XDG_DATA_DIRS to the function comment and removing the comment in the
code. Would that be acceptable?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org
sniperrifle updated this revision to Diff 70537.
sniperrifle added a comment.
Diff to the proper upstream
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25604?vs=70536&id=70537
REVISION DETAIL
https://phabricator.kde.org/D25604
AFFECTED FILES
sniperrifle updated this revision to Diff 70536.
sniperrifle added a comment.
Condensed the overly verbose comments into a single sentence capturing the
essence of the original comments and use splitRef instead of split.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> startplasma.cpp:188
>
> -// Make sure that the KDE prefix is first in XDG_DATA_DIRS and that it's
> set at all.
> -// The spec allows XDG_DATA_DIRS to b
sniperrifle created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sniperrifle requested review of this revision.
REVISION SUMMARY
This patch ensures the XDG_DATA_DIRS will be properly altered and only when
necessary. This implies:
- If the data roo
