D25310: Use the right value of EnableMagicMimeActions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:895e31d6946b: Use the right value of EnableMagicMimeActions (authored by trmdi, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25310

D25310: Use the right value of EnableMagicMimeActions

trmdi updated this revision to Diff 70933. trmdi added a comment. Remove unneeded code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25310?vs=69759&id=70933 BRANCH fix-enableMagicMimeActions REVISION DETAIL https://phabricator.kde.org/D25310

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ah, I think like you, just following the existing code. :D In D25310#572211 , @davidedmundson wrote: > I can't really object, as you're just following the existing code, but I don't really understand why we're doing t

D25310: Use the right value of EnableMagicMimeActions

davidedmundson added a comment. I can't really object, as you're just following the existing code, but I don't really understand why we're doing this. INLINE COMMENTS > urlgrabber.cpp:106 > -KConfigGroup cg(KSharedConfig::openConfig(), "Actions"); > -if(!cg.readEntry("EnableMagicMime

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ping! REPOSITORY R120 Plasma Workspace BRANCH fix-enableMagicMimeActions (branched from master) REVISION DETAIL https://phabricator.kde.org/D25310 To: trmdi, #plasma, ngraham, apol Cc: ngraham, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbamp

D25310: Use the right value of EnableMagicMimeActions

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Seems sensible to implement this the way reading all the other actions are implemented. #plasma people, is this okay? REPOSITORY R120 Plasma W

D25310: Use the right value of EnableMagicMimeActions

trmdi created this revision. trmdi added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 409801 TEST PLAN The bug is fixed. REPOSITORY R120 Plasma Workspace BRANCH fix-enableMagic