This revision was automatically updated to reflect the committed changes.
Closed by commit R169:4a9820a6df15: Make QmlComponentsPool one instance per
engine (authored by davidedmundson).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25284?vs=69697&id=69760
davidedmundson updated this revision to Diff 69697.
davidedmundson added a comment.
reduce lookup
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25284?vs=69671&id=69697
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D25284
AFFECTED FILES
broulik added inline comments.
INLINE COMMENTS
> columnview.cpp:51
> +Q_ASSERT(engine);
> +if(privateQmlComponentsPoolSelf->m_instances.contains(engine)) {
> +return privateQmlComponentsPoolSelf->m_instances[engine];
Avoid double lookup:
auto *componentPool = privateQmlCompone
davidedmundson created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
If we create 2 engines in an application the singleton is initialised to
the first engine. If that first engine di
