D25205: Remove pointless QDBusServiceWatcher

2019-11-10 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in KSMServer.cpp:45 > This is also a perfect candidate for dbus xml? It absolutely is. But one change at a time. REPOSITORY R161 KActivity Manager Service REVISION DETAIL https://phabricator.kde.org/D25205 To: davidedmu

D25205: Remove pointless QDBusServiceWatcher

2019-11-10 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > KSMServer.cpp:45 > KSMServer::Private::Private(KSMServer *parent) > -: serviceWatcher(new QDBusServiceWatcher(this)) > -, kwin(nullptr) > +: kwin(new QDBusInterface(KWIN_SERVICE, QStringLiteral("/KWin"), > QStringLiteral("org.kde.KWin

D25205: Remove pointless QDBusServiceWatcher

2019-11-10 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R161:35e5dc950e8f: Remove pointless QDBusServiceWatcher (authored by davidedmundson). REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25205?vs=69425&id=

D25205: Remove pointless QDBusServiceWatcher

2019-11-08 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY KActivitymanagerd's ksmserver has a QDBusServiceWatcher in order to recreat