D25196: Perform KNS searches from the Featured page again

2019-11-08 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R134:11d79794b58e: Perform KNS searches from the Featured page again (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25196?vs=69407

D25196: Perform KNS searches from the Featured page again

2019-11-07 Thread Nathaniel Graham
ngraham updated this revision to Diff 69407. ngraham edited the summary of this revision. ngraham added a comment. Update comment REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25196?vs=69396&id=69407 BRANCH restore-kns-entries-in-searche

D25196: Perform KNS searches from the Featured page again

2019-11-07 Thread Nathaniel Graham
ngraham marked an inline comment as done. ngraham added a comment. Sure, master only is fine. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D25196 To: ngraham, apol, #discover_software_store Cc: aspotashev, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25196: Perform KNS searches from the Featured page again

2019-11-07 Thread Aleix Pol Gonzalez
apol added a comment. How about we target master for this? INLINE COMMENTS > KNSBackend.cpp:507 > return stream; > -} else if ((m_hasApplications && !filter.category) // If there is no > category defined, we are searching in the root, and should include only > application resul

D25196: Perform KNS searches from the Featured page again

2019-11-07 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY We previously disabled this in https://bugs.kde.org/show_bug.cgi?id=399503 t