This revision was automatically updated to reflect the committed changes.
ahiemstra marked an inline comment as done.
Closed by commit R169:2fe7e4598871: Add a displayHint property to Action
(authored by ahiemstra).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
ahiemstra marked 3 inline comments as done.
ahiemstra added inline comments.
INLINE COMMENTS
> leinir wrote in Action.qml:124
> You're right, NoPreference would probably be more linguistically correct... i
> was more thinking along the lines of, if the default means there is no
> preferred hint
ahiemstra updated this revision to Diff 69462.
ahiemstra added a comment.
- Add and use DisplayHint.NoPreference value for displayHint default
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25176?vs=69358&id=69462
BRANCH
action_displayhint
REVISION DET
leinir added inline comments.
INLINE COMMENTS
> broulik wrote in Action.qml:124
> Isn't it more like a "no preference" value?
> Also, please document the default value
You're right, NoPreference would probably be more linguistically correct... i
was more thinking along the lines of, if the defa
broulik added inline comments.
INLINE COMMENTS
> leinir wrote in Action.qml:124
> Might be nice to have a DisplayHint.NoHint value, to make it more explicit
> what that 0 means
Isn't it more like a "no preference" value?
Also, please document the default value
REPOSITORY
R169 Kirigami
REVIS
leinir added inline comments.
INLINE COMMENTS
> Action.qml:124
> + */
> +property int displayHint: 0
> +
Might be nice to have a DisplayHint.NoHint value, to make it more explicit what
that 0 means
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D25176
To: ah
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
This property can be used to indicate preferences on how to display the
action to impl
