D24942: Require and use the new NewStuffQuick Button component

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c21a8bd82ec2: Require and use the new NewStuffQuick Button component (authored by leinir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24942?vs=68958&id=6

D24942: Require and use the new NewStuffQuick Button component

leinir added a comment. In D24942#556062 , @ngraham wrote: > Thanks, that fixes the issue. This works quite well now. > > Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :)

D24942: Require and use the new NewStuffQuick Button component

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, that fixes the issue. This works quite well now. Would be nice to address the bugs I filed before 5.18 is released so it really gets polished up all nice and shiny. :) REPOSI

D24942: Require and use the new NewStuffQuick Button component

leinir updated this revision to Diff 68958. leinir added a comment. Together with the change in D25041 this makes the model reloading work (without that patch, it simply fails quietly as the signal forwarding fails). If wanted, we could also use the cou

D24942: Require and use the new NewStuffQuick Button component

ngraham added a comment. Nice. However it doesn't seem to work for me. If I install a theme using the dialog, it doesn't show up in the Global Themes KCM. Could it because of a typo (`changedEntryes.count()`) ? I've filed a bunch of bug reports regarding polishing the dialog itself:

D24942: Require and use the new NewStuffQuick Button component

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This removes the need for the custom hack for spawning a dialog, and is intended to function as a sample for how to implement this