D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Does it make sense to have the option off by default, i.e. hiding the clock on idle by default? "Given that the setting will be off by default," is not true. By default the clock is shown, so nothing changes here, also given a static image is also our default.

D24893: [Lock Screen] Add option to hide clock when idle

colomar added a comment. In D24893#558506 , @ngraham wrote: > In D24893#558451 , @mart wrote: > > > clock "always show" is fine too tough > > > Given that the setting will be off by default, its

D24893: [Lock Screen] Add option to hide clock when idle

This revision was automatically updated to reflect the committed changes. Closed by commit R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when idle (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24893?vs=68622&id=6938

D24893: [Lock Screen] Add option to hide clock when idle

ngraham added a comment. In D24893#558451 , @mart wrote: > clock "always show" is fine too tough Given that the setting will be off by default, its opposite state is clear enough I'd say. It's not the best string ever, but maybe we should

D24893: [Lock Screen] Add option to hide clock when idle

mart added a comment. clock "always show" is fine too tough REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24893: [Lock Screen] Add option to hide clock when idle

mart added a comment. Instead of explicitly talking about clockwhat about a "Only show wallpaper when idle?" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n

D24893: [Lock Screen] Add option to hide clock when idle

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in WallpaperFader.qml:145 > Why are we changing this line? The clock shadow effectively renders the clock (shader effect with source hidden), so it has to be hidden. > davidedmundson wrote in config.qml:21 > One thing Thomas

D24893: [Lock Screen] Add option to hide clock when idle

davidedmundson added inline comments. INLINE COMMENTS > WallpaperFader.qml:145 > target: clock.shadow > -opacity: 1 > +opacity: wallpaperFader.alwaysShowClock ? 1 : 0 > +} Why are we changing this line? > config.qml:21 > +

D24893: [Lock Screen] Add option to hide clock when idle

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh nice! Shipit! Works great. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24893 To: broulik, #plasma, #vdg, ngraham Cc: ngraham, plasma-devel, LeGas

D24893: [Lock Screen] Add option to hide clock when idle

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This allows to use it for a slideshow or something. TEST PLAN F7658739: Screenshot_20191023

D24893: [Lock Screen] Add option to hide clock when idle

broulik added a comment. > Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional? That's the trick! The config comes *from the theme* (similar to how plasmoids do it), so only our theme will have those check boxes. IN

D24893: [Lock Screen] Add option to hide clock when idle

ngraham added a comment. This should make a lot of people happy. :) Is there a way to suppress these settings when you're using a theme that doesn't make the clock and media controls optional? INLINE COMMENTS > config.qml:5 > > -RowLayout { > +ColumnLayout { > +property alias cfg_