meven added inline comments.
INLINE COMMENTS
> apol wrote in ksplashqml.desktop.cmake:7
> Are you sure the wayland interface is required?
>
> It seems like the warning is broken, so we could just as well remove it.
I agree, it seems `org_kde_plasma_window_management` is so simple we should
gra
apol added inline comments.
INLINE COMMENTS
> ksplashqml.desktop.cmake:7
> +Type=Application
> +X-KDE-Wayland-Interfaces=org_kde_plasma_window_management
> +
Are you sure the wayland interface is required?
It seems like the warning is broken, so we could just as well remove it.
REPOSITORY
R1
meven updated this revision to Diff 68987.
meven marked an inline comment as done.
meven added a comment.
ksplashqml is not a dbus service
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24856?vs=68738&id=68987
BRANCH
arcpatch-D24856_2
REVISION
meven marked an inline comment as done.
meven added inline comments.
INLINE COMMENTS
> ksplashqml.desktop.cmake:8
> +X-DBUS-StartupType=Unique
> +X-DBUS-ServiceName=org.kde.ksplashqml
> +X-KDE-StartupNotify=false
I think X-DBUS-* may not be necessary here.
> ngraham wrote in ksplashqml.desktop.
meven updated this revision to Diff 68738.
meven added a comment.
Rebase on master
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24856?vs=68737&id=68738
BRANCH
arcpatch-D24856_1
REVISION DETAIL
https://phabricator.kde.org/D24856
AFFECTED FI
meven updated this revision to Diff 68737.
meven added a comment.
Add GenericName
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24856?vs=68520&id=68737
BRANCH
arcpatch-D24856_1
REVISION DETAIL
https://phabricator.kde.org/D24856
AFFECTED FIL
ngraham added inline comments.
INLINE COMMENTS
> ksplashqml.desktop.cmake:3
> +Exec=@CMAKE_INSTALL_PREFIX@/bin/ksplashqml
> +Name=ksplashqml
> +NoDisplay=true
Human readable name please
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24856
To: meven, apol, #p
meven created this revision.
meven added reviewers: apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
To prevent warnings in kwin such as :
kwin_core: Did not grant the interface "org_kde_plasma_wind
